Clean up command handling in hdp.c/h #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derobins
commented
Sep 13, 2023
derobins
commented
- Move list of commands inside hdp.c
- Remove HDP_MASTER scheme
- Tie command string & enum value together in a struct to keep in sync
- Minor tidying
* Move list of commands inside hdp.c * Remove HDP_MASTER scheme * Tie command string & enum value together in a struct to keep in sync * Minor tidying
derobins
added
Component - Tools
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
commented
Sep 13, 2023
| #ifdef HDP_MASTER | ||
| = {"help", "list", "dumpsds", "dumprig", "dumpvg", "dumpvd", "dumpgr"} | ||
| #endif /* HDP_MASTER */ | ||
| ; |
There was a problem hiding this comment.
Moved into hdp.c since it's not used anywhere else
derobins
commented
Sep 13, 2023
| typedef struct command_t { | ||
| const command_value_t value; | ||
| const char *name; | ||
| } command_t; |
There was a problem hiding this comment.
Tying the enum value and string together into a struct ensures they will never be out of sync
Also return EXIT_FAILURE/SUCCESS instead of 1 and 0
derobins
commented
Sep 13, 2023
| if (cmd == BAD_COMMAND) { | ||
| printf("Invalid command: %s\n", argv[curr_arg]); | ||
| exit(EXIT_FAILURE); | ||
| } |
There was a problem hiding this comment.
Before we printed the value of cmd (in code below), which would just be the sentinel NONE value, which is unhelpful.
derobins
commented
Sep 13, 2023
| break; | ||
| } /* end switch */ |
There was a problem hiding this comment.
Printing the enum value was unhelpful. Printing the string is better, which we do above.
|
Test failures are due to GitHub flakiness and aren't real |
bmribler
approved these changes
Sep 13, 2023
lrknox
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.